Change OS specification in build workflow #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…those are specified
intendo
pushed a commit
that referenced
this pull request
Apr 29, 2022
* Fixed syntax errors in checking for max python version (#208) * Fixed syntax errors in checking for max python version * Switch OS specification to absolute versions and reduce places where those are specified * Update Windows config to Visual Studio 17 2022 * skip ci -- Updated releases.rst with update info * [skip ci] Added release note Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Change OS specification in build workflow (#210) * Switch OS specification to absolute versions and reduce places where those are specified * Update Windows config to Visual Studio 17 2022 * skip ci -- Updated releases.rst with update info Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> Co-authored-by: Darren Curtis <Darren.Curtis@pnnl.gov> * Nsoblath/issue 212 (#217) * Turn off debugging steps * Only install python in Windows for "Test Usage" job, as we'll be statically linking Python in Mac and Linux. * Search for static python libs in linux and mac when doing a static build * Turn on tmate to check library linking * Find threads explicitly * Tmate only on failure * Verbose build for debugging * Added two more missing libraries: libdl and libutil * Enable tmate for the mac use-test job * Test with Python 3.10 * Test with Python 3.10 revealed we needed libintl. So that's added now. Should be mac-specific * Can't include_directories() on an empty variable * Typo fix * Find Iconv * Add linking of APBS to CoreFoundation framework under macOS * Remove debugging * Removing some of the debugging tools used in testing the build. * Switch back to the standard build with Python 3.9 * Removed last tmate debugging * [skip ci] Document changes Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Nsoblath/issue 222 (#223) * First committed version of Dockerfile.centos * Add alt config workflow * Alt config build: test docker builds * In Dockerfile, specify APBS_STATIC_BUILD instead of BUILD_SHARED_LIBS * Missing backslash found * Fixing bugs in both Dockerfiles * Dockerfile bug fixing * Complete missing pieces of ensuring a position-independent-code build * Minor fixes * Switch to a shared-library build in the Ubuntu Docker build * Rename Dockerfile --> Dockerfile.ubuntu * Override APBS_STATIC_BUILD when needed Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Remove all mention of ENABLE_FETK (#225) Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Nsoblath/issue 226: FETK update (#227) * Address missing linkages * Cleanup FETK import * Multithreaded build in docker now controlled by a build argument * Install superlu as a dependency in the Ubuntu docker build * Update the FETK version in use by the automatic builds (still on a development branch) * Add in debugging tmate session for mac * Manually build arpack to get the static lib (which seems to have disappeared?) * Remove -j flags * Set fortran compiler for arpack build * Engaging brain, fixing mac-build commands * Comment out tmate session * Update the FETK commit to be the main branch, pre-release * Update the changelog * Updated default FETK build to commit v1.9.3 (57195e) Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Nsoblath/new issue 207: Addressing python version test (#229) * Fix python test max-version test in apbs/CMakeLists.txt * Turn on the alternate non-docker builds, with updates from the main build * Fixing the python max version test in apbs/tests/CMakeLists.txt * Fixing the python max version test in apbs/tools/python/CMakeLists.txt * Test commit: remove python-max-version definition * Simplify the Python search by looking for an exact version * Add a default PYTHON_VERSION * Adapt the various files involved in building APBS to the new Python version setup * Didn't setup the python version correctly in the GHA builds Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Updated installation documentation (#231) Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> * Updated license, version, and release info for pending release Co-authored-by: Noah Oblath <noah.oblath@pnnl.gov> Co-authored-by: Darren Curtis <Darren.Curtis@pnnl.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209