-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
manager.get.currentMatches
returns only Locked and Completed
#172
Labels
bug
Something isn't working
Comments
Hey @Tandashi! Sorry for the delay. I'm working on it, and thank you for reporting the issue 😄 |
All good. Thanks for the heads up :) |
@Tandashi could you try with the PR I opened? To test it, you can do the following:
|
Will do in a bit :) |
Fix released in v1.5.9 😉 |
Tandashi
added a commit
to kocxyz/XYZBot
that referenced
this issue
Jun 30, 2023
Updated the `brackets-manager` to the latest version which fixed the bye completion issue. Reference: Drarig29/brackets-manager.js#172
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently I am running into the problem that
manager.get.currentMatches
only returnsLocked
andCompleted
matches.It doesn't return the matches of the next round as expected.
The round contains 3 Matches where Participants have BYE matches (so participant vs no-one) and 1 Participant vs Participant match. Do I need to update the BYE matches manually to mark as completed?
(I would assume no if I understand to method Doc correctly)
If that is not the case here is my quick issue analysis.
A Match that has a BYE it will always get the status
Locked
(we'll see later why).However the
manager.get.currentMatches
function checks if a rounds is completed as follows:Since the
Locked
Status has a value of0
this will never cause the round to be completed, thus returning a list ofLocked
andCompleted
Matches.I would assume that the issue lies somewhere here:
The first
if
check will always cause a Match to get theLocked
Status if it contains aBYE
.Thus
isMatchCompleted
, which also accounts for BYE's, will never be reach.Simply returning the
Completed
Status instead of theLocked
one in the first return could already solve the issue.The text was updated successfully, but these errors were encountered: