Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ci_visibility): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set #7656

Merged
merged 5 commits into from
Nov 20, 2023
Merged

chore(ci_visibility): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set #7656

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
34c14c7
override API answer if ITR_FORCE_ENABLED is set
ericlaz Nov 17, 2023
60f4940
move env var to should_collect_coverage
ericlaz Nov 17, 2023
2a76821
fmt
ericlaz Nov 17, 2023
f27871f
Merge branch '2.x' into eric.navarro/fix-env-var-cov
ericlaz Nov 20, 2023
b3d3ba0
Merge branch '2.x' into eric.navarro/fix-env-var-cov
ericlaz Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ddtrace/internal/ci_visibility/recorder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,9 @@ def __init__(self, tracer=None, config=None, service=None):

@staticmethod
def _should_collect_coverage(coverage_enabled_by_api):
if not coverage_enabled_by_api:
if not coverage_enabled_by_api and not asbool(
os.getenv("_DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE", default=False)
):
return False
if compat.PY2:
log.warning("CI Visibility code coverage tracking is enabled, but Python 2 is not supported.")
Expand Down Expand Up @@ -240,8 +242,6 @@ def _check_enabled_features(self):
return False, False

attributes = parsed["data"]["attributes"]
if asbool(os.getenv("_DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE", default=False)):
return True, attributes["tests_skipping"]
return attributes["code_coverage"], attributes["tests_skipping"]

def _configure_writer(self, coverage_enabled=False, requests_mode=None):
Expand Down
Loading