Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci_visibility): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set #7656

Merged
merged 5 commits into from
Nov 20, 2023

Conversation

ericlaz
Copy link
Contributor

@ericlaz ericlaz commented Nov 17, 2023

Motivation

This PR moves the _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE to the _should_collect_coverage() function to override API answers.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy
  • If this PR touches code that signs or publishes builds or packages, or handles credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.

@ericlaz ericlaz added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Nov 17, 2023
@ericlaz ericlaz changed the title fix(civis): Override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set fix(civis): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set Nov 17, 2023
@ericlaz ericlaz marked this pull request as ready for review November 17, 2023 17:07
@ericlaz ericlaz requested review from a team as code owners November 17, 2023 17:07
@pr-commenter
Copy link

pr-commenter bot commented Nov 17, 2023

Benchmarks

Benchmark execution time: 2023-11-17 17:46:35

Comparing candidate commit 2a76821 in PR branch eric.navarro/fix-env-var-cov with baseline commit 3920b07 in branch 2.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 metrics, 0 unstable metrics.

@romainkomorndatadog romainkomorndatadog changed the title fix(civis): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set chore(ci_visibility): override API answer if _DD_CIVISIBILITY_ITR_FORCE_ENABLE_COVERAGE is set Nov 20, 2023
@ericlaz ericlaz enabled auto-merge (squash) November 20, 2023 10:15
@ericlaz ericlaz merged commit d0e50ca into 2.x Nov 20, 2023
141 checks passed
@ericlaz ericlaz deleted the eric.navarro/fix-env-var-cov branch November 20, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR. CI App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants