Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go mod #46

Closed
wants to merge 9 commits into from
Closed

Go mod #46

wants to merge 9 commits into from

Conversation

jniesen
Copy link

@jniesen jniesen commented Feb 14, 2019

Summary of Changes:

  • Enables go modules by placing the GO111MODULE=on env var in the Makefile
  • Add clean and deps targets to the Makefile
    • clean will run go clean and remove an previously created releases
    • deps will run go mod tidy; go get -u; go mod vendor to
      • remove any no longer needed deps
      • download any deps missing from the dev/build environment
      • populate/update the vendor directory
  • Creates a go module for this project, remove Dep files and bring vendor dir under go mod management.

@jniesen
Copy link
Author

jniesen commented Feb 20, 2019

Failing because of one of these most likely:
golang/go#27925 (comment)
golang/go#29278 (comment)

@americk0 americk0 mentioned this pull request Jun 11, 2020
@americk0
Copy link
Member

I'm closing this in favor of #80 which does essentially the same thing. Thank you jniesen for starting this off even if it did take us a year and a half to get back around to

@americk0 americk0 closed this Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants