Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make debug handler customizable #1667

Merged
merged 9 commits into from
Apr 25, 2023
Merged

Make debug handler customizable #1667

merged 9 commits into from
Apr 25, 2023

Conversation

webmaster128
Copy link
Member

@webmaster128 webmaster128 commented Apr 20, 2023 •
edited
Loading

An alternative route to solve the issues behind #1642 and #1643.

The example test gives us the following, but it is highly customizable:

---- instance::tests::create_gas_report_works stdout ----
here we go 🚀 (gas: 695828950000, runtime: 543µs)
here we go 🚀 (gas: 690131799729, runtime: 1868µs)
here we go 🚀 (gas: 684434649458, runtime: 3173µs)

@webmaster128 webmaster128 mentioned this pull request Apr 20, 2023
Closed
@webmaster128 webmaster128 changed the title Make dubug handler customizable Make debug handler customizable Apr 20, 2023
maurolacy
maurolacy reviewed Apr 20, 2023
View reviewed changes
packages/vm/src/imports.rs Show resolved Hide resolved
packages/vm/src/instance.rs Outdated Show resolved Hide resolved
@webmaster128 webmaster128 marked this pull request as ready for review April 25, 2023 07:48
@webmaster128 webmaster128 mentioned this pull request Apr 25, 2023
Closed
@webmaster128 webmaster128 merged commit 54e3e78 into main Apr 25, 2023
@webmaster128 webmaster128 deleted the debug-harder branch April 25, 2023 08:55
@maurolacy maurolacy mentioned this pull request Apr 28, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurolacy maurolacy maurolacy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@webmaster128 @maurolacy