Add debug_with_gas functionality
#1643
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maurolacy
force-pushed
the
feature/debug_with_gas
branch
from
ad61d0c
to
de46e31
Compare
|
Any plans on merging this? Can rebase and solve conflicts if that is the case. |
| let message_data = read_region(&env.memory(), message_ptr, MAX_LENGTH_DEBUG)?; | ||
| let msg = String::from_utf8_lossy(&message_data); | ||
| let gas_remaining = env.get_gas_left(); | ||
| println!("{}, gas_left: {}", msg, gas_remaining); |
There was a problem hiding this comment.
This is something we can also easily add to the output of the current debug implementation (for the same reasons I mentioned in the trace PR)
maurolacy
force-pushed
the
feature/debug_with_gas
branch
from
de46e31
to
0eb0e68
Compare
|
Closing in favour of #1667. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe closes #746.
Similar to #1642, prints a debug message but with remaining gas information, for benchmarking / optimisation / regression.
Instead of returning the gas to the contract, this just prints the amount of remaining gas; which is probably less problematic, and still pretty useful.