Allow multiple carto clients using Google Maps #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanmalagon
approved these changes
Jun 26, 2018
| if (overlayIndex >= 0) { | ||
| this.gmapsMap.overlayMapTypes.removeAt(overlayIndex); | ||
| overlays.setAt(overlayIndex, overlays.getAt(overlayIndex)); |
There was a problem hiding this comment.
This seems a bit strange since we're setting the overlay at the same exact place. I guess that setAt triggers something internally in Google Maps. If not, this has no much sense.
There was a problem hiding this comment.
It's basically a reload, before we were doing remoteAt 0 -> setAt 0, but just doing setAt works fine.
jesusbotella
approved these changes
Jul 5, 2018
|
I've tested the acceptance example as well as builder with gmaps and it seems like all's good in da hood |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2132
Description
This PR allows to use multiple carto clients when using Google Maps.
We had a few problems:
GMapsCartoDBLayerGroupView, and always usingsetAt(0, layer)which was overriding other layer groups added previously by other clients.GoogleMapsMapTypeto themap.overlayMapTypesarray, but checking forGMapsCartoDBLayerGroupViewinstances, so we never found them.map.overlayMapTypes.pushand telling our users to do the same, which lead to duplicated map types.map.overlayMapTypes(in the example) for each layer, which works with Leaflet because it uses an object and internal layer ids, but not with google maps which just uses an array, we should document this somehow, clients have to call it once for each carto client / layer group.I solved it by adding an internal
idto both,GoogleMapsMapTypeandGMapsCartoDBLayerGroupView, and check thatidinstead of usingindexOf(this).It seems to be working, although
map.overlayMapTypescan contain two different things depending on where it's being used (builder or public api).I've also checked Leaflet, but since it works differently we don't have that problem.