Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layers not added in GMaps wheen using multiple clients #2132

Closed
ivanmalagon opened this issue Jun 7, 2018 · 1 comment
Closed

Layers not added in GMaps wheen using multiple clients #2132

ivanmalagon opened this issue Jun 7, 2018 · 1 comment
Labels
Milestone

Comments

@ivanmalagon
Copy link
Contributor

ivanmalagon commented Jun 7, 2018

Context

A customer reported that their layers where not showing up.

After some triage, the problem is that internally we don't handle well the layers added to Google Maps when using layers from multiple clients.

This is a tricky issue since it affects the CARTO.js internals so we must proceed carefully.

Another insight from the ticket is that calling to getGoogleMapsMapType already adds it to Google Maps but then we are pushing the layer to the overlayMapTypes array, so it's twice in GMaps. Take a look on it too.

You can find a working HTML in support

Check in Leaflet as well.

WARNING
Be careful with this issue. Builder is working flawlessly since it only needs one client. Test it thoroughly or set a flag only in the public API to allow several clients.

@rubenmoya
Copy link
Contributor

Fixed in version 4.0.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants