Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Solution in oneD objects #1345

Merged
merged 12 commits into from
Sep 5, 2022
Merged

Integrate Solution in oneD objects #1345

merged 12 commits into from
Sep 5, 2022

Commits on Sep 4, 2022

  1. [OneD] Add docstrings for save/restore

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    a1dea26 View commit details
    Browse the repository at this point in the history

  2. [OneD] Deprecate StFlow::setThermo

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    8dafc21 View commit details
    Browse the repository at this point in the history

  3. [OneD] Introduce Solution manager to OneD

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    9f3a627 View commit details
    Browse the repository at this point in the history

  4. [OneD] Set pressure automatically

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    5dfb4cb View commit details
    Browse the repository at this point in the history

  5. [Python] Create OneD objects from Solution

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    a0d985f View commit details
    Browse the repository at this point in the history

  6. [UnitTest] Update oneD Python tests

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    c5979b9 View commit details
    Browse the repository at this point in the history

  7. [samples] Create StFlow from Solution

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    4e45896 View commit details
    Browse the repository at this point in the history

  8. Clarify nomenclature for Solution::setTransportModel

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    e123412 View commit details
    Browse the repository at this point in the history

  9. Clarify C++ transportType() as transportModel() and deprecate old method 

    Transport::transportType() is not consistent with nomenclature used in the
Python API, which uses Transport.transport_model.
    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    d3087fa View commit details
    Browse the repository at this point in the history

  10. Address review comments 

    Co-authored-by: Bryan Weber <bryan.w.weber@gmail.com>
    @ischoegl @bryanwweber
    ischoegl and bryanwweber committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    3b76b5d View commit details
    Browse the repository at this point in the history

  11. [oneD] Deprecate Sim1D::solution/getSolution

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    54f4f19 View commit details
    Browse the repository at this point in the history

  12. [OneD] Clarify docstring for StFlow::m_trans_shared

    @ischoegl
    ischoegl committed Sep 4, 2022
    Configuration menu
    Copy the full SHA
    1f34cfe View commit details
    Browse the repository at this point in the history