Integrate Solution in oneD objects #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
3 times, most recently
from
ff0665a
to
b4ef404
Compare
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
3 times, most recently
from
c5e0c83
to
3c9463b
Compare
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
from
3c9463b
to
0e42b69
Compare
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
from
81cfbd9
to
0111336
Compare
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
2 times, most recently
from
a9918c5
to
88f514a
Compare
|
Rebased to latest |
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
from
88f514a
to
2957c95
Compare
|
@speth ... thank you for the review! |
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
2 times, most recently
from
090ed85
to
781c8c2
Compare
Transport::transportType() is not consistent with nomenclature used in the Python API, which uses Transport.transport_model.
Co-authored-by: Bryan Weber <bryan.w.weber@gmail.com>
ischoegl
force-pushed
the
preamble-to-native-solutionarray
branch
from
781c8c2
to
1f34cfe
Compare
speth
approved these changes
Sep 4, 2022
bryanwweber
approved these changes
Sep 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
StFlowobjects fromSolutionTransport::transportModelconsistentThe PR excludes
clib/ctonedim, whereSolutionis currently completely absent.If applicable, fill in the issue number this pull request is fixing
Preliminary work for Cantera/enhancements#137
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage