Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update YAML Sphinx documentation #1249

Merged
merged 6 commits into from
Apr 25, 2022
Merged

Update YAML Sphinx documentation #1249

merged 6 commits into from
Apr 25, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Apr 24, 2022

Changes proposed in this pull request

If applicable, fill in the issue number this pull request is fixing

Closes #1198

see also: Cantera/cantera-website#199

If applicable, provide an example illustrating new features this pull request is introducing

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@ischoegl ischoegl requested a review from a team April 24, 2022 17:36
@ischoegl ischoegl marked this pull request as draft April 24, 2022 17:44
@ischoegl ischoegl marked this pull request as ready for review April 24, 2022 18:12
@ischoegl ischoegl force-pushed the update-docs branch 5 times, most recently from 51ce92c to 28ea5e7 Compare April 24, 2022 23:45
@ischoegl
Copy link
Member Author

@speth / @bryanwweber ... ended up revising a little more, but it's done / ready for review now.

Copy link
Member

@speth speth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks, @ischoegl!

@speth speth merged commit ab8aee9 into Cantera:main Apr 25, 2022
@ischoegl ischoegl deleted the update-docs branch April 28, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update reactions.rst to reflect changes to be introduced in Cantera 2.6
2 participants