Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update description of three-body and surface reactions #199

Merged
merged 4 commits into from
Apr 29, 2022

Conversation

ischoegl
Copy link
Member

@ischoegl ischoegl commented Apr 24, 2022

  • Add reference to implict third body collider
  • Revise section describing surface and sticking reactions

See also Cantera/cantera#1249

@ischoegl ischoegl force-pushed the revise-reaction-documentation branch 2 times, most recently from 1e29528 to baefd85 Compare April 24, 2022 18:10
@ischoegl ischoegl force-pushed the revise-reaction-documentation branch 2 times, most recently from 655027e to 16b6447 Compare April 26, 2022 01:51
* Add reference to implict third body collider
* Revise sections describing surface and sticking reactions
@ischoegl ischoegl force-pushed the revise-reaction-documentation branch from 16b6447 to 5124e9f Compare April 26, 2022 01:53
@ischoegl ischoegl force-pushed the revise-reaction-documentation branch from 5124e9f to ae9c466 Compare April 26, 2022 02:22
@ischoegl ischoegl requested a review from a team April 26, 2022 02:32
Copy link
Member

@bryanwweber bryanwweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ischoegl just a couple small comments for discussion.

pages/science/kinetics.rst Outdated Show resolved Hide resolved
pages/science/kinetics.rst Outdated Show resolved Hide resolved
@ischoegl ischoegl marked this pull request as draft April 27, 2022 03:48
@ischoegl ischoegl force-pushed the revise-reaction-documentation branch 2 times, most recently from d6b603a to cf84cb5 Compare April 27, 2022 11:42
@ischoegl ischoegl force-pushed the revise-reaction-documentation branch from cf84cb5 to f631f27 Compare April 27, 2022 12:15
@ischoegl ischoegl marked this pull request as ready for review April 27, 2022 12:35
@ischoegl
Copy link
Member Author

Fixed links ... I believe this is ready.

@ischoegl
Copy link
Member Author

@bryanwweber … are you 👍 with the updates?

@bryanwweber bryanwweber merged commit 1576289 into Cantera:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants