-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update description of three-body and surface reactions #199
Merged
bryanwweber
merged 4 commits into
Cantera:main
from
ischoegl:revise-reaction-documentation
Apr 29, 2022
Merged
Update description of three-body and surface reactions #199
bryanwweber
merged 4 commits into
Cantera:main
from
ischoegl:revise-reaction-documentation
Apr 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischoegl
force-pushed
the
revise-reaction-documentation
branch
2 times, most recently
from
April 24, 2022 18:10
1e29528
to
baefd85
Compare
5 tasks
ischoegl
force-pushed
the
revise-reaction-documentation
branch
2 times, most recently
from
April 26, 2022 01:51
655027e
to
16b6447
Compare
* Add reference to implict third body collider * Revise sections describing surface and sticking reactions
ischoegl
force-pushed
the
revise-reaction-documentation
branch
from
April 26, 2022 01:53
16b6447
to
5124e9f
Compare
ischoegl
force-pushed
the
revise-reaction-documentation
branch
from
April 26, 2022 02:22
5124e9f
to
ae9c466
Compare
bryanwweber
approved these changes
Apr 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @ischoegl just a couple small comments for discussion.
ischoegl
force-pushed
the
revise-reaction-documentation
branch
2 times, most recently
from
April 27, 2022 11:42
d6b603a
to
cf84cb5
Compare
ischoegl
force-pushed
the
revise-reaction-documentation
branch
from
April 27, 2022 12:15
cf84cb5
to
f631f27
Compare
Fixed links ... I believe this is ready. |
@bryanwweber … are you 👍 with the updates? |
bryanwweber
approved these changes
Apr 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See also Cantera/cantera#1249