Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing netconf-confirmed-commit #1552

Merged
merged 3 commits into from
Apr 15, 2024
Merged

Conversation

lePici
Copy link
Collaborator

@lePici lePici commented Mar 15, 2024

Notification for YANG module ietf-netconf-notifications.

@lePici lePici force-pushed the notif branch 4 times, most recently from 1f3b6ea to 6223b9b Compare March 21, 2024 11:06
Notifications are moved to common.c file.
@lePici lePici force-pushed the notif branch 2 times, most recently from 9d0388a to e09bd95 Compare March 27, 2024 15:08
src/common.c Outdated Show resolved Hide resolved
Creating a notification via the libyang API.
@lePici lePici force-pushed the notif branch 2 times, most recently from 3f3d0da to 3f5976c Compare April 10, 2024 13:43
@lePici lePici marked this pull request as ready for review April 10, 2024 13:50
Copy link
Member

@michalvasko michalvasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks almost perfect, just one minor comment and also please reference issue 1548 in the commit adding the new notification.

src/netconf_confirmed_commit.c Outdated Show resolved Hide resolved
@michalvasko michalvasko merged commit b17f851 into CESNET:devel Apr 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants