Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to generate netconf-confirmed-commit notification #1548

Open
chunlovemail opened this issue Mar 10, 2024 · 3 comments
Open

How to generate netconf-confirmed-commit notification #1548

chunlovemail opened this issue Mar 10, 2024 · 3 comments
Labels
is:enhancement Request for adding new feature or enahncing functionality. status:completed From the developer perspective, the issue was solved (bug fixed, question answered,...)

Comments

@chunlovemail
Copy link

sh-5.1# sysrepoctl -h
sysrepoctl - sysrepo YANG schema manipulation tool, compiled with libsysrepo v2.1.84 (SO v7.8.10)

sh-5.1# netopeer2-server -V
netopeer2-server 2.1.36

Use netopeer2-cli to connect server and execute "subscribe" to receive notifications. I modify the candidate data and execute "commit --confirm-timeout 120". I can see the "netconf-config-change", but here is NO "netconf-confirmed-commit ",

After this, I execute command "commit --confirmed-commit", there is still NO "netconf-confirmed-commit "

Am my procedure WRONG? or the "netconf-confirmed-commit" notification is NOT support in the laster code?

@michalvasko
Copy link
Member

Actually, we have completely missed this notification and it is not implemented and never sent. It is not a priority but I have noted it and we will implement it once there is some spare time, will reply here.

@michalvasko michalvasko added the is:enhancement Request for adding new feature or enahncing functionality. label Mar 11, 2024
@chunlovemail
Copy link
Author

Hi Michalvasko,
Thanks for your response, I got it

lePici added a commit to lePici/netopeer2 that referenced this issue Apr 15, 2024
michalvasko pushed a commit that referenced this issue Apr 15, 2024
@lePici
Copy link
Collaborator

lePici commented Apr 16, 2024

Sending netconf-confirmed-commit notifications has been implemented. Please try it by updating Netopeer's devel branch.

@michalvasko michalvasko added the status:completed From the developer perspective, the issue was solved (bug fixed, question answered,...) label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is:enhancement Request for adding new feature or enahncing functionality. status:completed From the developer perspective, the issue was solved (bug fixed, question answered,...)
Projects
None yet
Development

No branches or pull requests

3 participants