Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated CHANGELOG.md and pubspec.yaml within the platform_interface #916

Merged
merged 2 commits into from
Sep 20, 2022

Conversation

YannickMaljaars
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

permission_handler_platform_interface version update for these documentation changes.

⤵️ What is the current behavior?

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

826

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

@YannickMaljaars YannickMaljaars marked this pull request as ready for review September 20, 2022 13:57
@codecov
Copy link

codecov bot commented Sep 20, 2022

Codecov Report

Base: 86.51% // Head: 86.51% // No change to project coverage 👍

Coverage data is based on head (e67d978) compared to base (cf903f7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #916   +/-   ##
=======================================
  Coverage   86.51%   86.51%           
=======================================
  Files           6        6           
  Lines          89       89           
=======================================
  Hits           77       77           
  Misses         12       12           
Impacted Files Coverage Δ
..._platform_interface/lib/src/permission_status.dart 66.66% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mvanbeusekom mvanbeusekom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mvanbeusekom mvanbeusekom merged commit ec5623f into Baseflow:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants