-
-
Notifications
You must be signed in to change notification settings - Fork 839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated permission_status.dart comments #914
Conversation
Codecov ReportBase: 86.51% // Head: 86.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #914 +/- ##
=======================================
Coverage 86.51% 86.51%
=======================================
Files 6 6
Lines 89 89
=======================================
Hits 77 77
Misses 12 12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small suggestions.
permission_handler_platform_interface/lib/src/permission_status.dart
Outdated
Show resolved
Hide resolved
permission_handler_platform_interface/lib/src/permission_status.dart
Outdated
Show resolved
Hide resolved
permission_handler_platform_interface/lib/src/permission_status.dart
Outdated
Show resolved
Hide resolved
permission_handler_platform_interface/lib/src/permission_status.dart
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for the open suggestion that is still open. When that is fixed feel free to merge the pull request.
permission_handler_platform_interface/lib/src/permission_status.dart
Outdated
Show resolved
Hide resolved
…s.dart Updated according to suggestion Co-authored-by: Maurits van Beusekom <maurits@baseflow.com>
Updated
permission_handler_platform_interface\lib\src\permission_status.dart
comments to better reflect current funtionality✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Docs update
🆕 What is the new behavior (if this is a feature change)?
💥 Does this PR introduce a breaking change?
No
🐛 Recommendations for testing
📝 Links to relevant issues/docs
Issue 826
🤔 Checklist before submitting
master
.