Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove in Place from conjugate comments #13078

Merged
merged 2 commits into from
Oct 10, 2022
Merged

remove in Place from conjugate comments #13078

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e81b6f
remove in Place from conjugate comments
BabylonJSGuide Oct 8, 2022
c9b4f9e
removes 1 - q from quaternion conjugate
BabylonJSGuide Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/dev/core/src/Maths/math.vector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3993,7 +3993,7 @@ export class Quaternion {
}

/**
* Conjugates (1-q) the current quaternion and stores the result in the given quaternion
* Conjugates the current quaternion and stores the result in the given quaternion
* @param ref defines the target quaternion
* @returns the current quaternion
*/
Expand All @@ -4003,7 +4003,7 @@ export class Quaternion {
}

/**
* Conjugates in place (1-q) the current quaternion
* Conjugates in place the current quaternion
* @returns the current updated quaternion
*/
public conjugateInPlace(): Quaternion {
Expand All @@ -4014,7 +4014,7 @@ export class Quaternion {
}

/**
* Conjugates in place (1-q) the current quaternion
* Conjugates (1-q) the current quaternion
* @returns a new quaternion
*/
public conjugate(): Quaternion {
Expand Down