Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove in Place from conjugate comments #13078

Merged
merged 2 commits into from
Oct 10, 2022
Merged

remove in Place from conjugate comments #13078

merged 2 commits into from
Oct 10, 2022

Conversation

BabylonJSGuide
Copy link
Contributor

@azure-pipelines
Copy link

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@azure-pipelines
Copy link

Snapshot stored with reference name:
refs/pull/13078/merge

Test environment:
https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13078/merge/index.html

To test a playground add it to the URL, for example:

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/13078/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/13078/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/13078/merge
https://gui.babylonjs.com/?snapshot=refs/pull/13078/merge
https://nme.babylonjs.com/?snapshot=refs/pull/13078/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/13078/merge#BCU1XR#0

@BabylonJSGuide
Copy link
Contributor Author

( 1 - q) = (0, 0, 0, 1) - (x, y, z, w) = (-x, -y, - z, 1-w) ≠ (-x, -y, -z, w)

@RaananW RaananW merged commit 263fe2a into BabylonJS:master Oct 10, 2022
RaananW pushed a commit that referenced this pull request Dec 9, 2022
@BabylonJSGuide
remove in Place from conjugate comments (#13078)
81639f7 
* remove in Place from conjugate comments

* removes 1 - q from quaternion conjugate

Former-commit-id: 1d46004454f1f30d113e93bd8dfdbee205373375
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaananW RaananW RaananW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BabylonJSGuide @RaananW