Update mustache package to fix PHP 8 error. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also seems to fix this issue: Yoast/wordpress-seo#17453. |
|
But I'm getting this error: |
|
@bonakor That appears to be coming from the scb-framework package which is used in this plugin. |
|
It's making it not that easy to update. Thanks for the heads up What would you recommend @jeffreyvr ? |
|
@bonakor Think I'll use my forked version until the official plugin gets updated. Might also fork the wp-scb-framework package while I'm at it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of the mustache package that is included in the plugin causes an fatal error with PHP 8.
This pull request updates the package to the latest version. I have also added the packages to
composer.jsonto allow for quicker updates in the future.I haven't found any issues after applying these changes. Tested with PHP 8 and 7.4, but should also work on 5.6.