Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posts to posts and Yoast SEO compatibility #17453

Closed
6 of 9 tasks
bonakor opened this issue Sep 26, 2021 · 3 comments
Closed
6 of 9 tasks

Posts to posts and Yoast SEO compatibility #17453

bonakor opened this issue Sep 26, 2021 · 3 comments

Comments

@bonakor
Copy link

bonakor commented Sep 26, 2021

  • I've read and understood the contribution guidelines.
  • I've searched for any related issues and avoided creating a duplicate issue.

When activated with Posts To posts plugin, the principal category picker send this error.

i@https://tennismajors.test/app/plugins/wordpress-seo/js/dist/post-edit-1720.js:1:137732
constructClassInstance@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:13011:9
updateClassComponent@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:17235:29
beginWork@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:18755:18
callCallback@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:182:16
invokeGuardedCallbackDev@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:231:18
invokeGuardedCallback@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:286:33
beginWork$1@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:23338:30
performUnitOfWork@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:22289:14
workLoopSync@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:22265:24
performSyncWorkOnRoot@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:21891:11
flushSyncCallbackQueueImpl/<@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:11224:26
unstable_runWithPriority@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react.js?ver=16.13.1:2685:14
runWithPriority$1@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:11174:12
flushSyncCallbackQueueImpl@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:11219:26
flushSyncCallbackQueue@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:11207:5
scheduleUpdateOnFiber@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:21334:11
dispatchAction@https://tennismajors.test/wp/wp-includes/js/dist/vendor/react-dom.js?ver=16.13.1:15795:19
onStoreChange@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:3442:9
onChange@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:3458:9
instantiate/subscribe</<@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:2150:13
dispatch@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:1001:7
createMiddleware/</</<@https://tennismajors.test/wp/wp-includes/js/dist/redux-routine.js?ver=fd5f93d1f8206c65d1891cf1f898211e:240:16
promiseMiddleware/</<@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:1620:10
createResolversCacheMiddleware/</</<@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:1664:10
dispatch@https://tennismajors.test/wp/wp-includes/js/dist/data.js?ver=a9e98fe3ad76884fe7909ba8348395b7:1351:28
unhandledActionControl@https://tennismajors.test/wp/wp-includes/js/dist/redux-routine.js?ver=fd5f93d1f8206c65d1891cf1f898211e:200:13
next/<@https://tennismajors.test/wp/wp-includes/js/dist/redux-routine.js?ver=fd5f93d1f8206c65d1891cf1f898211e:893:18
next@https://tennismajors.test/wp/wp-includes/js/dist/redux-routine.js?ver=fd5f93d1f8206c65d1891cf1f898211e:892:18
yieldValue/<@https://tennismajors.test/wp/wp-includes/js/dist/redux-routine.js?ver=fd5f93d1f8206c65d1891cf1f898211e:884:17

Please describe what you expected to happen and why.

The principal term or category picker says there is an error.

How can we reproduce this behavior?

  1. Activate Yoast in 17.1 version
  2. Activate and make use of posts to posts plugin in your theme. For instance, you can add this to your functions.php
add_action('init', function () {
    p2p_register_connection_type( array(
        'name' => 'multiple_authors',
        'title' => 'Author role',
        'from' => 'user',
        'to' => [0 => 'post'],
        'fields' => array(
            'role' => array( 
                'title' => 'Role',
                'type' => 'select',
                'values' => array( __('Writer', 'sage'), __('Co-writer', 'sage'), __('Editor', 'sage'), __('Photo', 'sage'), __('Translator', 'sage'), __('Curator', 'sage'), __('Author', 'sage'), __('Columnist', 'sage'), __('Expert', 'sage'))
            ),
        )
    ) );
});

Technical info

  • If relevant, which editor is affected (or editors):
  • Classic Editor
  • Gutenberg
  • Classic Editor plugin
  • Which browser is affected (or browsers):
  • Chrome
  • Firefox
  • Safari
  • Other

Used versions

  • WordPress version: 5.8.1
  • Yoast SEO version: 17.2
  • Gutenberg plugin version: not relevant
  • Classic Editor plugin version: not relevant
  • Relevant plugins in case of a bug: Posts To Posts 1.6.6
  • Tested with theme: Twentytwenty one
@bonakor
Copy link
Author

bonakor commented Sep 26, 2021

With Wordpress 5.6, it's working.

I managed to make it work with Wordpress 5.8.1 by uploading the Posts To Posts dependencies. :)

@Djennez
Copy link
Member

Djennez commented Sep 27, 2021

It looks like the posts 2 posts plugin is pretty outdated (if you're talking about https://wordpress.org/plugins/posts-to-posts/). Are you sure the problem isn't on their end?

@bonakor
Copy link
Author

bonakor commented Sep 27, 2021

I think the issue is on their end, yes. And I asked them to merge a PR fixing this issue. So we can consider this issue closed and resolved. Except if you'd like to takeover Posts 2 Posts maintenance^^

@bonakor bonakor closed this as completed Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants