Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Type error in requestFromUrl #29043

Merged
merged 1 commit into from
Dec 4, 2018
Merged

Commits on Dec 3, 2018

  1. Fix: Type error in requestFromUrl

    When using `requestFromUrl()` in #29026 we noticed errors being thrown
    from within `waitForData()`. Investigation revealed this basic type
    error that could have been caught by a language and compiler before it
    was pushed to production. Yay JS.
    
    This wasn't detected because this function isn't yet being used and we
    weren't sure how to test it. Thankfully our fail-fast methodology
    prevented this from appearing to our customers.
    dmsnell committed Dec 3, 2018
    Configuration menu
    Copy the full SHA
    c71a84a View commit details
    Browse the repository at this point in the history