Gutenlypso: Load translations #29026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmtr
added
[Status] In Progress
i18n
[Goal] Gutenberg
mmtr
commented
Dec 3, 2018
dmsnell
added a commit
that referenced
this pull request
Dec 3, 2018
When using `requestFromUrl()` in #29026 we noticed errors being thrown from within `waitForData()`. Investigation revealed this basic type error that could have been caught by a language and compiler before it was pushed to production. Yay JS. This wasn't detected because this function isn't yet being used and we weren't sure how to test it. Thankfully our fail-fast methodology prevented this from appearing to our customers.
gwwar
added
[Status] Needs Review
gwwar
approved these changes
Dec 4, 2018
dmsnell
added a commit
that referenced
this pull request
Dec 4, 2018
When using `requestFromUrl()` in #29026 we noticed errors being thrown from within `waitForData()`. Investigation revealed this basic type error that could have been caught by a language and compiler before it was pushed to production. Yay JS. This wasn't detected because this function isn't yet being used and we weren't sure how to test it. Thankfully our fail-fast methodology prevented this from appearing to our customers.
gwwar
force-pushed
the
update/gutenberg-translations
branch
from
c383277
to
9d78988
Compare
dmsnell
approved these changes
Dec 4, 2018
gwwar
added
[Status] Needs Review
matticbot
removed
the
[Status] Needs Review
|
This fixes #28724 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
This PR adds the translations to the locale data needed by the Gutenberg editor, so the sidebar is translated and we no longer have a discrepancy between the user language and the language used by Gutenberg:
Testing instructions
Note
This currently has 2 problems:
It cannot load 2 translations files at the same time, so right now the Jetpack blocks translations are not loaded (see Gutenlypso: Load translations #29026 (comment)).Solved in 8b8571a by using superagent andPromise.allAfter setting the locale data withSolved in e94732a after using the default domain.setLocaleData, I don't see any translated content, so I'm not sure what it's going on. I'm applying the same approach as D21408-code.