Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 5.0 support, tag version 1.3.2.2 #58

Merged
merged 3 commits into from
Nov 7, 2018
Merged

WordPress 5.0 support, tag version 1.3.2.2 #58

merged 3 commits into from
Nov 7, 2018

Conversation

benlk
Copy link
Collaborator

@benlk benlk commented Nov 7, 2018 •
edited
Loading

Changes

Why

Fixes #57.

Testing/Questions

Steps to test this PR:

  1. Install/activate WordPress 5.0-beta1, 5.0-beta2, 5.0-beta3 or later
  2. activate this plugin
  3. go to a post editor
  4. add a Pym.js Embeds block to the editor
  5. Check the browser javascript console to make sure there are no errors.

post-merge tasks

  • git tag -s v1.3.2.2 -m "Pym.js Embeds version 1.3.2.2"
  • release.sh

@benlk benlk added this to the 1.3.2.2 milestone Nov 7, 2018
@benlk benlk merged commit 47b51db into master Nov 7, 2018
@benlk benlk deleted the 57-requires-for-5.0 branch November 7, 2018 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: bug type: pre-launch todo
Projects
None yet
Milestone
1.3.2.2
Development

Successfully merging this pull request may close these issues.
1 participant
@benlk