Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor JS not enqueued in WordPress 5.0-beta versions #57

Closed
benlk opened this issue Nov 7, 2018 · 2 comments
Closed

Editor JS not enqueued in WordPress 5.0-beta versions #57

benlk opened this issue Nov 7, 2018 · 2 comments
Labels
priority: high type: bug
Milestone
1.3.2.2

Comments

@benlk
Copy link
Collaborator

benlk commented Nov 7, 2018 •
edited
Loading

As far as I can tell, the Pym.js Embeds block does not work in 5.0-beta3, 5.0-beta2, or 5.0-beta1.

This is part of #54.
@benlk benlk added this to the 1.3.2.2 milestone Nov 7, 2018
@benlk benlk changed the title Editor JS not enqueued in WordPress 5.0-beta3 Editor JS not enqueued in WordPress 5.0-beta version. Nov 7, 2018
@benlk benlk changed the title Editor JS not enqueued in WordPress 5.0-beta version. Editor JS not enqueued in WordPress 5.0-beta versions Nov 7, 2018
@benlk
Copy link
Collaborator Author

benlk commented Nov 7, 2018

The block is successfully registered, going be the output of the register_block_type call, but its assets do not appear to be enqueued, as I monitor the network queries.

@benlk
Copy link
Collaborator Author

benlk commented Nov 7, 2018

This is because of the Gutenberg -> WP transition; see WordPress/gutenberg#11069 for additional details.

@benlk benlk mentioned this issue Nov 7, 2018
Merged
2 tasks
@benlk benlk closed this as completed in #58 Nov 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: high type: bug
Projects
None yet
Milestone
1.3.2.2
Development

No branches or pull requests
1 participant
@benlk