-
Notifications
You must be signed in to change notification settings - Fork 799
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Social Menu & Social Media Icons: Add Threads support #31873
Conversation
Fixes #31768 Update the icon font, the social icons widget, the social menu, the social-logos package to include the new Threads icon. Related PR: Automattic/social-logos#122
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Once your PR is ready for review, check one last time that all required checks (other than "Required review") appearing at the bottom of this PR are passing or skipped. Jetpack plugin:
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
This does work for me when adding the widgets, but visiting https://firm-mole.jurassic.ninja/wp-content/plugins/jetpack/_inc/social-logos/social-logos.html doesn't show the logo. I'm not sure if that means something else will be broken that I didn't think to test. |
You would have to go to https://firm-mole.jurassic.ninja/wp-content/plugins/jetpack-dev/_inc/social-logos/social-logos.html (the dev version) to see it. |
shakes off sabbatical dust |
I suspect this broke the social icons on wpcom for a bit when released p1689640150536069-slack-CBG1CP4EN Automattic/wp-calypso#79502 |
This is a follow-up of #31873.
Sorry about that! #31932 should fix things. |
Fixes #31768
Proposed changes:
Update the icon font, the social icons widget, the social menu, the social-logos package to include the new Threads icon.
Related PR: Automattic/social-logos#122
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions:
yoursite.com/wp-content/plugins/jetpack/_inc/social-logos/social-logos.html
footer.php
for examplehttps://www.facebook.com/jetpackme
andhttps://www.threads.net/@tconrad