Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Sites: Social Media Icons Missing from Sharing Buttons #79502

Closed
jerrysarcastic opened this issue Jul 17, 2023 · 4 comments
Closed

Simple Sites: Social Media Icons Missing from Sharing Buttons #79502

jerrysarcastic opened this issue Jul 17, 2023 · 4 comments
Labels
[Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. [Platform] Simple [Pri] High Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report

Comments

@jerrysarcastic
Copy link

jerrysarcastic commented Jul 17, 2023 •
edited by cuemarie
Loading

Quick summary

Sharing buttons show an empty box where an icon should be rendered instead

Steps to reproduce

  1. Activate Twenty Twenty on test site Open a simple WordPress.com site
  2. Set sharing buttons to any setting that has icons (Icons & Text, Icon Only, Official Buttons)
  3. Save settings and view any post on the site

What you expected to happen

Icon to be displayed

What actually happened

Empty box is shown where the icon should go. Tested with Icons & Text, Icon Only, Official Buttons settings. In all cases there were missing icons, but note that if you test the Official Buttons setting, some buttons will show icons and some will not, likely due to how we are fetching the official button, which may vary by service

Impact

Some (< 50%)

Available workarounds?

No but the platform is still usable

Platform (Simple and/or Atomic)

Simple

Logs or notes

Only workaround for the moment is to direct the site owner to set the "Text Only" option for buttons. CSS and custom icons may also be a workaround but I have not tested it
@jerrysarcastic jerrysarcastic added [Type] Bug [Feature Group] Appearance & Themes Features related to the appearance of sites. User Report This issue was created following a WordPress customer report Needs triage Ticket needs to be triaged labels Jul 17, 2023
@github-actions github-actions bot added [Platform] Simple [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Jul 17, 2023
@cuemarie cuemarie added [Pri] Normal and removed [Pri] High [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts labels Jul 17, 2023
@cuemarie
Copy link

cuemarie commented Jul 18, 2023 •
edited
Loading

📌 SCRUBBING : RESULT - Replicated / Could Not Replicate / Uncertain

  • Tested on Simple – Replicated
  • Tested on Atomic – Could Not Replicate

📌 FINDINGS/SCREENSHOTS/VIDEO

  • Replicated on Simple site using multiple themes, both Classic and FSE
    • Themes Replicated: TT, TT1, TT2, TT3 on simple

Screenshots/Recordings

Firefox 115.0.2 (64-bit)

Markup on 2023-07-17 at 16:56:47

Simple Site, Twenty Twenty
Markup on 2023-07-17 at 16:57:06

Simple Site, TT3
Markup on 2023-07-17 at 16:59:25

Atomic Site, TT3
Markup on 2023-07-17 at 17:01:13

📌 ACTIONS

  • Assigned to @Automattic/loop

@cuemarie cuemarie changed the title Twenty Twenty: Social Media Icons Missing from Sharing Buttons Simple Sites: Social Media Icons Missing from Sharing Buttons Jul 18, 2023
@cuemarie cuemarie added Triaged To be used when issues have been triaged. Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. [Pri] High and removed [Feature Group] Appearance & Themes Features related to the appearance of sites. Needs triage Ticket needs to be triaged [Pri] Normal labels Jul 18, 2023
@github-actions github-actions bot added the [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts label Jul 18, 2023
@cuemarie
Copy link

Escalated here: p1689638734304199-slack-C03NLNTPZ2T

@roo2 roo2 mentioned this issue Jul 18, 2023
Merged
3 tasks
@roo2
Copy link
Contributor

roo2 commented Jul 18, 2023

fixed for now by reverting jetpack release. I suspect it was introduced with this commit to jetpack, but I'll leave it for them to investigate Automattic/jetpack#31873

@roo2 roo2 closed this as completed Jul 18, 2023
@jeherve
Copy link
Member

jeherve commented Jul 18, 2023

In Automattic/jetpack#31932 I'm taking another pass at this.

@cuemarie cuemarie added the [Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. label Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Closed] Resolved Issue is resolved. Use for issues that can be closed but did not have an explicit fix with a PR. [Platform] Simple [Pri] High Simple/Atomic Parity For issues related to feature parity between Simple and Atomic sites. [Status] Priority Review Triggered Quality squad has been notified of this issue in #dotcom-triage-alerts Triaged To be used when issues have been triaged. [Type] Bug User Report This issue was created following a WordPress customer report
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jeherve @jerrysarcastic @roo2 @cuemarie