Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top Posts Widget: provide defaults for newly added param. #15395

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Top Posts Widget: provide defaults for newly added param. #15395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions modules/widgets/top-posts.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,12 +525,15 @@ public function get_by_likes( $count, $types = array( 'post', 'page' ) ) {
/**
* Get the top posts based on views
*
* @since 8.4.0 Added $types param
*
* @param int $count The maximum number of posts to be returned.
* @param array $args The widget arguments.
* @param array $types The post types that should be returned.
* @return array array of posts.
*
* @return array array of posts. Defaults to 'post' and 'page'.
*/
public function get_by_views( $count, $args, $types ) {
public function get_by_views( $count, $args, $types = array( 'post', 'page' ) ) {
if ( defined( 'IS_WPCOM' ) && IS_WPCOM ) {
global $wpdb;

Expand Down