Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Top Posts Widget: provide defaults for newly added param. #15395

Merged
merged 1 commit into from
Apr 9, 2020
Merged

Top Posts Widget: provide defaults for newly added param. #15395

merged 1 commit into from
Apr 9, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Apr 9, 2020

Changes proposed in this Pull Request:

  • $types was added in 8.4, but we did not add a default value when it's not provided.

See #15109 for more details.

This was reported in 2860860-zen.

Testing instructions:

  • In a third party plugin (functionality plugin, add a function that calls Jetpack_Top_Posts_Widget::get_by_views with 2 parameters instead of 3.
  • No fatal error should occur.

Proposed changelog entry for your changes:

  • Top Posts Widget: provide default for newly added parameter to avoid errors when using third-party plugins interacting with stats.

@jeherve
Top Posts Widget: provide defaults for newly added param.
6a830e9 
$types was added in 8.4, but we did not add a default value when it's not provided.

See #15109 for more details.
@jeherve jeherve added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] BLOCKER [Status] Needs Cherry-Pick labels Apr 9, 2020
@jeherve jeherve added this to the 8.4.2 milestone Apr 9, 2020
@jeherve jeherve requested a review from leogermani April 9, 2020 14:59
@jeherve jeherve requested a review from a team as a code owner April 9, 2020 14:59
@jeherve jeherve self-assigned this Apr 9, 2020
@matticbot matticbot added Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". Touches WP.com Files labels Apr 9, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D41649-code before merging this PR. Thank you!

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 5, 2020.
Scheduled code freeze: April 28, 2020

Generated by 🚫 dangerJS against 6a830e9

jeherve added a commit that referenced this pull request Apr 9, 2020
@jeherve
Changelog: add #15395
ccd1fbe
@kraftbj kraftbj merged commit feeadaf into master Apr 9, 2020
@kraftbj kraftbj deleted the fix/fatal-top-posts branch April 9, 2020 18:50
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 9, 2020
kraftbj pushed a commit that referenced this pull request Apr 9, 2020
@jeherve @kraftbj
[not verified] Top Posts Widget: provide defaults for newly added par…
2b405de 
…am. (#15395)

$types was added in 8.4, but we did not add a default value when it's not provided.

See #15109 for more details.
@kraftbj
Copy link
Contributor

kraftbj commented Apr 9, 2020

Cherry-pick to branch-8.4 via 2b405de.
r205645-wpcom

jeherve added a commit that referenced this pull request Apr 14, 2020
@jeherve
8.4.2: changelog (#15393)
35d8b21 
* 8.4.2 changelog: add #15365

* [not verified] Changelog: add #15372

* Changelog: add #15368

* Changelog: add #15395

* Changelog: add #15396

* Changelog: add #15406
jeherve added a commit that referenced this pull request Apr 14, 2020
@jeherve
[not verified] 8.4.2: changelog (#15393)
3ef358e 
* 8.4.2 changelog: add #15365

* [not verified] Changelog: add #15372

* Changelog: add #15368

* Changelog: add #15395

* Changelog: add #15396

* Changelog: add #15406
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

@leogermani leogermani Awaiting requested review from leogermani

Assignees

@jeherve jeherve

Labels
Customer Report Issues or PRs that were reported via Happiness. Previously known as "Happiness Request". [Feature] Extra Sidebar Widgets [Pri] BLOCKER Touches WP.com Files [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
8.4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jeherve @matticbot @jetpackbot @kraftbj