Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetpack Backup: update AAG status message to account for daily backups #14968

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Jetpack Backup: update AAG status message to account for daily backups #14968

merged 1 commit into from
Mar 17, 2020

Conversation

robertf4
Copy link
Contributor

Changes proposed in this Pull Request:

Before, the Backup card on the AAG dashboard would always display "We are backing up your site in real time" even if the site was on a plan that had daily backups:

image

This PR changes the display so that it will reflect the site plan and display daily or realtime as appropriate:

image

Is this a new feature or does it add/remove features to an existing part of Jetpack?

No

Testing instructions:

For a site with each of the following plans, visit /wp-admin/admin.php?page=jetpack#/dashboard and verify that the backup card displays the correct message:

  • Jetpack Backup Daily
  • Jetpack Backup Realtime
  • Jetpack Personal
  • Jetpack Premium
  • Jetpack Professional

Proposed changelog entry for your changes:

  • Fixed issue where plans with daily backups would see a message stating that the site is being backed up in real time.

@robertf4 robertf4 added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Feature] Backup & Scan labels Mar 12, 2020
@robertf4 robertf4 requested a review from a team March 12, 2020 21:13
@robertf4 robertf4 requested a review from a team as a code owner March 12, 2020 21:13
@robertf4 robertf4 self-assigned this Mar 12, 2020
@github-actions
Copy link
Contributor

Howdy! The Jetpack team has disappeared for a few days to a secret island lair to concoct new ways to make Jetpack one hundred billion percent better. As a result, your Pull Request may not be reviewed right away. Do not worry, we will be back next week to look at your work! Thank you for your understanding.

@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against af32b4b

zinigor
zinigor approved these changes Mar 17, 2020
View reviewed changes
Copy link
Member

@zinigor zinigor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well with both VaultPress (nothing changes) and Rewind!

@zinigor zinigor added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 17, 2020
@jeherve jeherve added this to the 8.4 milestone Mar 17, 2020
@jeherve jeherve added the [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it label Mar 17, 2020
@jeherve jeherve merged commit 354f0f0 into master Mar 17, 2020
@jeherve jeherve deleted the fix/daily-backup-aag-status-message branch March 17, 2020 13:36
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 17, 2020
jeherve added a commit that referenced this pull request Mar 23, 2020
@jeherve
Changelog: add #14968
1e1384f
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zinigor zinigor zinigor approved these changes

@jeherve jeherve jeherve approved these changes

Assignees

@robertf4 robertf4

Labels
[Feature] Backup & Scan [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.
5 participants
@robertf4 @jetpackbot @zinigor @jeherve @matticbot