Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General: update minimum WordPress version for Jetpack #14913

Merged
merged 5 commits into from
Mar 9, 2020
Merged

General: update minimum WordPress version for Jetpack #14913

merged 5 commits into from
Mar 9, 2020

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented Mar 6, 2020 •
edited
Loading

Changes proposed in this Pull Request:

WordPress 5.4 is scheduled for release before the next version of Jetpack will ship.

Let's consequently aim to update Jetpack to keep our WP-1 support standard.

I've taken the opportunity to try again to switch on Unit Tests on PHP 7.4 (see #14171) (Edit: nope, that still does not work, had to revert), and remove old shims.

Related PRs:

Testing instructions:

  • See PRs above for each functionality change.

Proposed changelog entry for your changes:

  • General: Jetpack now supports WordPress 5.3 and newer.

@jeherve
General: update minimum WordPress version for Jetpack
80b7b7d 
WordPress 5.4 is scheduled for release before the next version of Jetpack will ship.

Let's consequently aim to update Jetpack to keep our WP-1 support standard.
@jeherve
Remove temporary workarounds now that all Jetpack users use WP5.3+
438c2d5 
Also update date() into gmdate() as per WordPress coding standards changes.
@jeherve
Related Posts: remove workaround that is not necessary anymore
1c5a6ea
@jeherve jeherve added this to the 8.4 milestone Mar 6, 2020
@jeherve jeherve requested a review from kraftbj March 6, 2020 17:52
@jeherve jeherve requested a review from a team as a code owner March 6, 2020 17:52
@jeherve jeherve self-assigned this Mar 6, 2020
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello jeherve! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer, review, and approve D40014-code before merging this PR. Thank you!

@jetpackbot
Copy link

jetpackbot commented Mar 6, 2020 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: April 7, 2020.
Scheduled code freeze: March 31, 2020

Generated by 🚫 dangerJS against 0a3771e

@jeherve
Revert Travis changes for now
67207df 
We're still running into the same issues as in #14171
@kraftbj
Copy link
Contributor

kraftbj commented Mar 6, 2020

The previous branch may fail in Travis until 5.4 actually ships.

@kraftbj
Copy link
Contributor

kraftbj commented Mar 6, 2020

Travis may need to be 7.4snapshot instead of 7.4 to be added to the matrix.

@jeherve
Force all "Previous" WP version tests to be 5.3 for now
0a3771e 
We can move back to "previous" once WP 5.4 has shipped
@jeherve jeherve force-pushed the update/jp-wp-minimum-version branch from 2905ee3 to 0a3771e Compare March 6, 2020 18:48
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Mar 6, 2020
@zinigor zinigor merged commit 0bb2bee into master Mar 9, 2020
@zinigor zinigor deleted the update/jp-wp-minimum-version branch March 9, 2020 11:40
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Mar 9, 2020
@jeherve
Copy link
Member Author

jeherve commented Mar 17, 2020

r204379-wpcom

jeherve added a commit that referenced this pull request Mar 20, 2020
@jeherve
Changelog: add #14913
627cf26
jeherve added a commit that referenced this pull request Mar 31, 2020
@jeherve
8.4 Changelog (#15075)
0eb0b35 
* Initial changelog entry

* Changelog: add #14904

* Changelog: add #14910

* Changelog: add #14913

* Changelog: add #14916

* Changelog: add #14922

* Changelog: add #14924

* Changelog: add #14925

* Changelog: add #14928

* Changelog: add #14840

* Changelog: add #14841

* Changelog: add #14842

* Changelog: add #14826

* Changelog: add #14835

* Changelog: add #14859

* Changelog: add #14884

* Changelog: add #14888

* Changelog: add #14817

* Changelog: add #14814

* Changelog: add #14819

* Changelog;: add #14797

* Changelog: add #14798

* Changelog: add #14802

* Changelog: add #13676

* Changelog: add #13744

* Changelog: add #13777

* Changelog: add #14446

* Changelog: add #14739

* Changelog: add #14770

* Changelog: add #14784

* Changelog: add #14897

* Changelog: add #14898

* Changelog: add #14968

* Changelog: add #14985

* Changelog: add #15044

* Changelog: add #15052

* Update to remove Podcast since it remains in Beta

* Changelog: add #14803

* Changelog: add #15028

* Changelog: add #15065

* Changelog:add #14886

* Changelog: add #15118

* Changelog: add #14990

* Changelog: add #14528

* Changelog: add #15120

* Changelog: add #15126

* Changelog: add #15049

* Chanegelog: add #14852

* Changelog: add #15090

* Changelog: add #15138

* Changelog: add #15124

* Changelog:add #15055

* Changelog: add #15017

* Changelog: add #15109

* Changelog: add #15145

* Changelog:add #15096

* Changelog:add #15153

* Changelog: add #15133

* Changelog: add #14960

* Changelog: add #15127

* Changelog: add #15056

* Copy current changelog to changelog archive.

* Clarify changelog description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftbj kraftbj kraftbj approved these changes

Assignees

@jeherve jeherve

Labels
[Feature] Related Posts [Feature] Shortcodes / Embeds General Touches WP.com Files [Type] Janitorial
Projects
None yet
Milestone
8.4
Development

Successfully merging this pull request may close these issues.
5 participants
@jeherve @matticbot @jetpackbot @kraftbj @zinigor