Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'Don't show this again' link to dismiss promote job modal in the editor #2632

Merged
merged 4 commits into from
Nov 13, 2023

Conversation

yscik
Copy link
Contributor

@yscik yscik commented Nov 9, 2023

Fixes #2523

Changes Proposed in this Pull Request

  • Update the notice system to accommodate this modal as a notice
  • Add a 'Don't show this again' link to the modal that marks the notice as dismissed for the current user
  • Don't show the modal after it was dismissed

Testing Instructions

  • Create a new job listing, add title, and hit Publish
  • A 'Promote your job on our partner network' modal should pop up
  • Click 'Don't show this again' link. Modal should disappear.
  • Publish another job listing. Modal should not appear.
    --
  • To restore dismissed notices:
    • wp user meta delete 1 wp_job_manager_dismissed_notices (where 1 is the user ID)
    • wp option delete wp_job_manager_dismissed_notices for site-level notices
  • Double-check that dismissing regular notices keeps working
    --
  • Open the job listing page, and click on a Promote button
  • Check that the Don't show this again link is not showing

Release Notes

  • Fix: Add 'Don't show this again' link to dismiss promote job modal in the editor

Screenshot / Video

image
Plugin build for 3179485
📦 Download plugin zip
▶️ Open in playground

Base automatically changed from feature/upsells to trunk November 9, 2023 15:48
@yscik yscik added this to the 2.0.0 milestone Nov 9, 2023
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! Left a few comments.

@yscik yscik requested a review from gikaragia November 10, 2023 16:53
Copy link
Contributor

@gikaragia gikaragia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good works well!

@yscik yscik merged commit ba9b424 into trunk Nov 13, 2023
8 checks passed
@yscik yscik deleted the add/dismiss-promote-modal branch November 13, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a link to not display the promote modal again when publishing a job
2 participants