Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPSEXP-933: Add node selector for deployments on ACS Helm Chart #673

Merged
merged 5 commits into from
Mar 23, 2022

Conversation

Mieszko96
Copy link
Contributor

@Mieszko96 Mieszko96 commented Mar 17, 2022

Ref. OPSEXP-933

@Mieszko96 Mieszko96 requested a review from a team March 17, 2022 15:36
Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I read it. Current implem would make ALL pods scheduled to the same kubernetes nodes. A nodeSelector should be "set-able" for each pod without bringing all the others pods with him.

@Mieszko96
Copy link
Contributor Author

I don't think if it is necessary for every pod to have their own value. But if you think we want this i can add seperate value for every pod e.g values.imagemagick.nodeSelector

@mteodori
Copy link
Member

I don't think if it is necessary for every pod to have their own value. But if you think we want this i can add seperate value for every pod e.g values.imagemagick.nodeSelector

for maximum flexibility I would go as suggested by @alxgomz to have a separate value per each component like the ingress one and a root value for components that are single service in the charts subdir

@alxgomz
Copy link
Contributor

alxgomz commented Mar 17, 2022

I don't think if it is necessary for every pod to have their own value. But if you think we want this i can add seperate value for every pod e.g values.imagemagick.nodeSelector

You're right that doesn't make sense for every pod. But just because you set a node selector for one, the other shouldn't have it. That's more what I meant.
Nodeselector make sense mainly for:
transformers (to isolate cpu load)
activemq & search & postgres & repo (for pv in simplistic config)
other thatn that... that would be just for more flexibility

@Mieszko96
Copy link
Contributor Author

Tested every deployment except deployment-ai-transformer.yaml
With extra values.

activemq:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
imagemagick:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
libreoffice:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
pdfrenderer:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
repository:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
share:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
tika:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
transformmisc:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
alfresco-digital-workspace:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
filestore:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
transformrouter:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
alfresco-search:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
alfresco-insight-zeppelin:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
insightzeppelin:
enabled: True
alfresco-sync-service:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
postgresql:
primary:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}
postgresql-syncservice:
primary:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}

ooi:
enabled: True
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}

msTeams:
enabled: True
msTeamsService:
nodeSelector: {"kubernetes.io/hostname": multinode-demo-m02}

helm/alfresco-content-services/README.md Outdated Show resolved Hide resolved
helm/alfresco-content-services/README.md Outdated Show resolved Hide resolved
@Mieszko96 Mieszko96 force-pushed the OPSEXP-933 branch 2 times, most recently from 9856d6a to 7994c35 Compare March 22, 2022 14:10
@Mieszko96 Mieszko96 requested a review from gionn March 22, 2022 15:35
@scila1996
Copy link

Please add their parameter

NodeAffinity
PodAffinity
Pod Tolerence

@gionn
Copy link
Member

gionn commented Mar 23, 2022

@scila1996 can you please open a new issue, describing why do you need them (which is your use case and why nodeSelector is insufficient)? Thanks.

Copy link
Contributor

@alxgomz alxgomz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mieszko96 Mieszko96 merged commit 0972b2c into master Mar 23, 2022
@Mieszko96 Mieszko96 deleted the OPSEXP-933 branch March 23, 2022 16:58
montgolfiere added a commit that referenced this pull request Apr 4, 2022
…r_compose

* master:
  OPSEXP-1374: Fix ooi and ms teams service - http 404 error (#684)
  fix formating error in doc [skip ci]
  OPSEXP-1348 use ACS_VERSION for build stages (#683)
  OPSEXP-1339 Update ingress-nginx to 4.x for k8s 1.22 (#682)
  OPSEXP-1226: Alfresco Control Center in ACS Deployment - docker-compose (#681)
  OPSEXP-933: Add node selector for deployments on ACS Helm Chart (#673)
  ACS-2671 Update alfresco-ai-docker-engine to 1.4.2 (#680)
  OPSEXP-1343 Remove 6.1.x config files (#679)
  OPSEXP-1035 Updated ActiveMQ to 5.16.4 (#661)
  ACS-2671 Pick up GA versions of Repo and Share in 7.2.0 (#678)

# Conflicts:
#	docker-compose/community-docker-compose.yml
#	docker-compose/docker-compose.yml
alxgomz pushed a commit that referenced this pull request Jan 23, 2024
* Add nodeSelectors to deployments

* Seperate NodeSelector values per pod

* add default to alfresco-insight-zeppelin

* rebase

* Move nodeSelector value from ooi to ooiservice and add comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nodeSelector to deployments activeMQ, filestore, repository and search
5 participants