Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: add option to prevent the time picker to close on overlay click #89

Closed
dkosasih opened this issue Dec 29, 2018 · 2 comments
Closed

Feat: add option to prevent the time picker to close on overlay click #89

dkosasih opened this issue Dec 29, 2018 · 2 comments

Comments

@dkosasih
Copy link

It would be great if we can have an option to prevent closing the modal when user click on the overlay.
At the moment time picker seems to not able to "force" user to pick a time mandatorily.
@Agranom
Copy link
Owner

Agranom commented Jan 7, 2019

Hi @dkosasih, no problem. I'll implement it

@Agranom Agranom mentioned this issue Jan 26, 2019
Merged
Agranom added a commit that referenced this issue Jan 26, 2019
@Agranom
Bugfixes and improvements (#81, #89, #97, #98, #103)
46012eb 
* bugfixes: ! fix endings

* bugfixes: + throw error if default minute doesn't fit to minutesGap

* bugfixes: + don't set minutesGap to 1 if value null or undefined (issue #98)

* bugfixes: * change time with minutesGap by using arrows (issue #103)

* ! lint fix

* feature/issue89: + add preventOverlayClick prop
@Agranom
Copy link
Owner

Agranom commented Jan 26, 2019

Done.

@Agranom Agranom closed this as completed Jan 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dkosasih @Agranom