Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard input doesn't work with minutesGap != 1 #103

Closed
sancaruso opened this issue Jan 22, 2019 · 3 comments
Closed

Keyboard input doesn't work with minutesGap != 1 #103

sancaruso opened this issue Jan 22, 2019 · 3 comments

Comments

@sancaruso
Copy link

sancaruso commented Jan 22, 2019 •
edited
Loading

If minutesGap is != 1 then the keyboard input doesn't work: we only can tip 0.
@sancaruso sancaruso changed the title Keyboard input don't work with minutesGap != 1 Keyboard input doesn't work with minutesGap != 1 Jan 22, 2019
Agranom pushed a commit that referenced this issue Jan 26, 2019
bugfixes: * change time with minutesGap by using arrows (issue #103)
eef1fbd
@Agranom Agranom mentioned this issue Jan 26, 2019
Merged
Agranom added a commit that referenced this issue Jan 26, 2019
@Agranom
Bugfixes and improvements (#81, #89, #97, #98, #103)
46012eb 
* bugfixes: ! fix endings

* bugfixes: + throw error if default minute doesn't fit to minutesGap

* bugfixes: + don't set minutesGap to 1 if value null or undefined (issue #98)

* bugfixes: * change time with minutesGap by using arrows (issue #103)

* ! lint fix

* feature/issue89: + add preventOverlayClick prop
@Agranom
Copy link
Owner

Agranom commented Jan 26, 2019

Updated the timepicker, so that you can change time by keyboard arrows including minutesGap. Hope it wiil help you

@Agranom Agranom closed this as completed Jan 26, 2019
@sancaruso
Copy link
Author

@Agranom would it be possible to display the message "* use arrows (⇅) to change the time" only when the time is focused? And is there an option to customize the message, typically for translation?

@Agranom
Copy link
Owner

Agranom commented Jan 29, 2019

would it be possible to display the message "* use arrows (⇅) to change the time" only when the time is focused?

yes, it would. I'll include it in the next release

And is there an option to customize the message, typically for translation?

Not for now. I have and idea to add locales, and maybe somehow ii can be combined

Agranom added a commit that referenced this issue Feb 16, 2019
@Agranom
Issues (#103, #108, #109, #112) (#113)
f43befc 
* issue109: ! fix bug with dead zone in 12 or 00 time section

* issue108: + add hourSelected event emitter

* + add test case

* issue112: + add opened event emitter

* + add linter to travis CI

* issue103: * show/hide dial hint onFocus/onBlur dial control

* * update changelog and version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Agranom @sancaruso