Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary #109

Merged
merged 7 commits into from
Apr 13, 2020
Merged

Glossary #109

merged 7 commits into from
Apr 13, 2020

Conversation

DavidBruant
Copy link
Contributor

I'm moving the glossary to the top-level

I added a definition for a "handle"

My hope is to have this PR merged quickly. Then, it'll be easy for anyone to add/fix/improve definitions

@DavidBruant
Copy link
Contributor Author

Thanks for the corrections @Chris-Hibbert !

Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes, some comments.

main/glossary/README.md Outdated Show resolved Hide resolved
main/glossary/README.md Outdated Show resolved Hide resolved
main/glossary/README.md Outdated Show resolved Hide resolved
main/glossary/README.md Outdated Show resolved Hide resolved
main/.vuepress/themeConfig/nav.js Outdated Show resolved Hide resolved
main/glossary/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you! We will need to manually deploy this for it to show up on the website

@DavidBruant
Copy link
Contributor Author

We will need to manually deploy this for it to show up on the website

Ok
I'm not familiar with the process. What are the steps to manually deploy?
Does it prevent from merging this PR in its current state?

@katelynsills
Copy link
Contributor

As discussed elsewhere, we can go ahead and merge. We will have to follow/run the deploy script to deploy it to the website: https://github.com/Agoric/documentation/blob/master/deploy.sh

DavidBruant and others added 7 commits April 13, 2020 12:12
Co-Authored-By: Chris Hibbert <Chris-Hibbert@users.noreply.github.com>
Co-Authored-By: Chris Hibbert <Chris-Hibbert@users.noreply.github.com>
Co-Authored-By: Kate Sills <katelynsills@gmail.com>
Co-Authored-By: Kate Sills <katelynsills@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants