Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zoe] zoe.chainmail concerns #496

Closed
3 tasks done
katelynsills opened this issue Feb 4, 2020 · 5 comments
Closed
3 tasks done

[Zoe] zoe.chainmail concerns #496

katelynsills opened this issue Feb 4, 2020 · 5 comments
Assignees
Labels
Zoe package: Zoe
Milestone

Comments

@katelynsills
Copy link
Contributor

katelynsills commented Feb 4, 2020

This Issue is updating the concerns mentioned in #98 by @DavidBruant for the current Zoe chainmail.

  • Explain what a "handle" is (an empty object as an id) and why we use it rather than a numeric id.
  • Define an instanceRecord struct and the other record structs from state.js
  • Explain why it is helpful to have an installation and install step separately (To have a unique identifier for specific contract code that can be referenced and reused. For example, once you have looked at the atomicSwap contract and saved the installationHandle for that code, you can look at any future invite and know for certain that if it used that installationHandle when the instance was created, it used code you examined.)
@katelynsills
Copy link
Contributor Author

@DavidBruant, is this something you could take on? If so, comment below (apparently commenting is necessary?) and I'll assign the task to you.

@DavidBruant
Copy link
Contributor

Explain what a "handle" is (an empty object as an id) and why we use it rather than a numeric id.

I added a defintion to the documentation glossary. See Agoric/documentation#109

I think it'll be enough, no need to add something to the chainmail about this

@katelynsills
Copy link
Contributor Author

Sounds good. What do you think about the other two task items? Also, @tyg is working on related issues writing up his Intro to Zoe.

@katelynsills katelynsills added this to the Zoe 0.5.0 milestone Apr 7, 2020
@DavidBruant
Copy link
Contributor

Define an instanceRecord struct and the other record structs from state.js

I addressed this in #878

Explain why it is helpful to have an installation and install step separately

I'm going to write something somewhere and when the intro to zoe is merged, we can figure out where the best place is for this

@katelynsills
Copy link
Contributor Author

Sounds great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

2 participants