get auction instance from promise returned by addAuction #9944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
9fc5ba9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0bb68d71.agoric-sdk.pages.dev |
| Branch Preview URL: | https://cth-auctioninstanceafter2.agoric-sdk.pages.dev |
dckc
approved these changes
Aug 22, 2024
Comment on lines
+69
to
+71
| (schedules.nextAuctionSchedule && | ||
| TimeMath.compareAbs(schedules.nextAuctionSchedule.startTime, now) > 0) || | ||
| Fail`Expected next start time in the future ${schedules.nextAuctionSchedule?.startTime}`; |
There was a problem hiding this comment.
I thought we'd log the schedule and eyeball it, but having the computer verify that it's fixed is perhaps more relevant.
Chris-Hibbert
added
the
automerge:rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9940
Description
#9937 unintentionally upgraded the vaultFactory with the instance of the old auction. This change asks the promise space for the auction instance after the new auction startup is complete.
Security Considerations
None.
Scaling Considerations
None.
Documentation Considerations
None.
###Testing Considerations
This will be tested on Ollinet and emerynet before deployment.
I tested locally on a3p by watching the logs to see that the vaults synced to the new auction schedule.
###Upgrade Considerations
upgrade vaults and auctions so they work together.