get auction instance from promise space after auction startup completes #9940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
approved these changes
Aug 22, 2024
| auctioneerInstanceP, | ||
| E.get(consumeInstance).auctioneer, |
There was a problem hiding this comment.
Interesting approach.
This PromiseSpace synchronization technique is clearly "too clever by half", since I didn't catch that in code review earlier.
I did start to suggest checking that agoricNames got updated, but only for the installation. And just checking that the instance changed in agoricNames wouldn't tell us which instance the vaultFactory picked up.
| instance: { consume: { auctioneer: uV } }, | ||
| instance: { consume: true }, |
There was a problem hiding this comment.
Granting more authority is often suspicious... but all the instances here are intended to be widely shared anyway. So this is fine.
Chris-Hibbert
added
the
automerge:rebase
Chris-Hibbert
force-pushed
the
cth-auctionInstanceAfter
branch
from
53462a9
to
20db104
Compare
Deploying agoric-sdk with
|
| Latest commit: |
20db104
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8155fdf1.agoric-sdk.pages.dev |
| Branch Preview URL: | https://cth-auctioninstanceafter.agoric-sdk.pages.dev |
Chris-Hibbert
removed
the
automerge:rebase
|
Superseded by #9944. |
mergify bot
added a commit
that referenced
this pull request
Aug 22, 2024
refs: #9940 ## Description #9937 unintentionally upgraded the vaultFactory with the instance of the old auction. This change asks the promise space for the auction instance after the new auction startup is complete. ### Security Considerations None. ### Scaling Considerations None. ### Documentation Considerations None. ###Testing Considerations This will be tested on Ollinet and emerynet before deployment. I tested locally on a3p by watching the logs to see that the vaults synced to the new auction schedule. ###Upgrade Considerations upgrade vaults and auctions so they work together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9937
Description
#9937 unintentionally upgraded the vaultFactory with the instance of the old auction. This change asks the promise space for the auction instance after the new auction startup is complete.
Security Considerations
none
Scaling Considerations
none
Documentation Considerations
none
Testing Considerations
This will be tested on Ollinet and emerynet before deployment.
I tested locally on
a3pby watching the logs to see that the vaults synced to the new auction schedule.Upgrade Considerations
upgrade vaults and auctions so they work together.