VowTools when honors rejection handler #9704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
65c5a0a
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://74f242e6.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mhofman-9703-fix-vowtools-wh.agoric-sdk.pages.dev |
erights
approved these changes
Jul 13, 2024
mhofman
changed the title
mergify bot
added a commit
that referenced
this pull request
Jul 14, 2024
follow up on #9449 ## Description #9685 unwrapped an `asVow()` to get the promise failure to propagate. This reverts that now that #9704 removed the need for it. ### Security Considerations none ### Scaling Considerations none ### Documentation Considerations none ### Testing Considerations CI ### Upgrade Considerations not yet deployed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9703
Description
Split
wheninto a baseunwrapand awhenhelper which accepts fulfillment and rejection handlersSecurity Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Added coverage for both
whenandwatchwithout handlersAdds vow rejection test in async-flow
Upgrade Considerations
None of the usages in upgrade-16 use a handler for
when, but we should incorporate this change in the upgrade-16 branch regardless and publish new NPM packages for dapps.