fix(vow): fix vow bug instead

[erights]

Staged on #9696

closes: #XXXX
refs: #XXXX

Description

@mhofman 's comment at #9696 (comment) indicated a puzzling rejection in a place that should not happen. If the code were correct, this extra .catch(reject) should not have been necessary, and should never do anything. The flaw in when.js is caused by the await at the top of

        result = await basicE(vowV0)
          .shorten()
          .then(
            res => {...},
            e => {
              ...
              throw e;
            },
          );

The problem is that if that onRejected clause happens, it throws e. That should be fine, because it is in a then which will turn that throw into a rejected promise. However the await at the top of the above snippet turns it back into a thrown error.

This PR does not remove that await. That turned out to be trickier than I expected. Rather, it surrounds most of the when code with a try/catch, turning any error thrown in the body into a call to the onRejected callback if present.

Reviewers, please review with whitespace differences turned off. Or, @turadg , feel free to simply merge this PR into your #9696.

Security Considerations

none beyond the usual: Correct code is better for security than incorrect code.

Scaling Considerations

none

Documentation Considerations

none

Testing Considerations

Would be good for this to be caught by a vow test. Attn @michaelfig

Upgrade Considerations

none

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	52e75a0
Status:	✅  Deploy successful!
Preview URL:	https://187d79e0.agoric-sdk.pages.dev
Branch Preview URL:	https://markm-fix-vow-bug-instead.agoric-sdk.pages.dev

View logs

[mhofman]

Way too complicated. Alternative PR incoming

[erights]

Closing in favor of #9704