adopt TypeScript 5.5

[turadg]

refs: #9152

Description

Typescript 5.5: https://devblogs.microsoft.com/typescript/announcing-typescript-5-5-rc/

(an earlier push also had #9479 but I moved the commits out)

Security Considerations

n/a, linting

Scaling Considerations

n/a, linting

Documentation Considerations

none

Testing Considerations

none

Upgrade Considerations

n/a, linting

[mhofman]

we could change E.when not to return a promise in that case.

Why would we do that? Because agoric-sdk doesn't chain with E.when doesn't mean it's not a possible use case. Also the fact that there is a handler doesn't mean a rejection is handled. I had seen misguided suppressions like that.

[turadg]

Why would we do that?

The paragraph you're quoting gives a reason why we would. If you're asking why should, I didn't claim we should. I was just spitballing.

Because agoric-sdk doesn't chain with E.when doesn't mean it's not a possible use case.

agoric-sdk does await E.when a handful of times. The quoted paragraph says "almost always void. Here's one,

  await E.when(outcomeOfUpdate, outcome => t.fail(`${outcome}`)).catch(e =>
    t.is(e, 'No quorum'),
  );

That could be done with passing a promise to .catch() and awaiting it after E.when, but that would be very awkward.

[mhofman]

LGTM

[mhofman]

Wondering if we should try to get rid of explicit ts-nocheck as much as possible. Maybe with some override config to disable checks wholesale where needed (e.g. cosmic-proto/codegen)

[turadg]

Eventually, yeah. We have 114 files with it outside codegen. Thankfully 93 of those are tests. 14 of the non-test ones are in SwingSet. Thankfully 13 are in misc-tools.

Just 2 non-codegen src files, so we could it up for src pretty easily. Another time tho.

[cloudflare-workers-and-pages]

Deploying agoric-sdk with    Cloudflare Pages

Latest commit:	381b6a8
Status:	✅  Deploy successful!
Preview URL:	https://cef5a023.agoric-sdk.pages.dev
Branch Preview URL:	https://ta-typescript-5-5.agoric-sdk.pages.dev

View logs

[michaelfig]

LGTM for the agoric-sdk. My approval is conditional on you answering my comment in a way that satisfies you. :)

[michaelfig]

This dependency on the dev.20240327 tag comes from @endo/eslint-plugin.

Would that cause problems? If so, maybe a packageJson.resolutions entry is in order? Could you consider creating an issue (or PR) on https://github.com/endojs/endo to fix those dependencies? Waiting until we update to the official 5.5 release is also acceptable.

[turadg]

I don't think it would create problems.

It'll line up after next sync endojs/endo#2326