Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add liveslots-provided globals to vat Compartments #1895

Merged
merged 2 commits into from
Oct 21, 2020
Merged

fix: add liveslots-provided globals to vat Compartments #1895

merged 2 commits into from
Oct 21, 2020

Commits on Oct 21, 2020

  1. chore: refactor worker setup 

    This just rearranges the order in which vat workers operate, so they do
`makeLiveslots` first, and `importBundle` second, to faciliate an upcoming
change that takes `vatGlobals` from liveslots and adds them into the
`importBundle` call. This should not change any visible behavior.
    @warner
    warner committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    bb5858a View commit details
    Browse the repository at this point in the history

  2. fix: add liveslots-provided globals to vat Compartments 

    Liveslots does not yet provide any `vatGlobals`, but this ensures that any
ones it does provide in the future will be added to the `endowments` on the
vat's Compartment. We'll use this to populate `makeExternalStore` -type
functions, which want to be globals (because threading them from `vatPowers`
into modules that need them would be too annoying), but must also be in
cahoots with closely-held WeakMaps and "Representative" state management code
from liveslots, as described in #455 and #1846.

closes #1867
    @warner
    warner committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    3c79d51 View commit details
    Browse the repository at this point in the history