fix: add liveslots-provided globals to vat Compartments #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This just rearranges the order in which vat workers operate, so they do `makeLiveslots` first, and `importBundle` second, to faciliate an upcoming change that takes `vatGlobals` from liveslots and adds them into the `importBundle` call. This should not change any visible behavior.
Liveslots does not yet provide any `vatGlobals`, but this ensures that any ones it does provide in the future will be added to the `endowments` on the vat's Compartment. We'll use this to populate `makeExternalStore` -type functions, which want to be globals (because threading them from `vatPowers` into modules that need them would be too annoying), but must also be in cahoots with closely-held WeakMaps and "Representative" state management code from liveslots, as described in #455 and #1846. closes #1867
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liveslots does not yet provide any
vatGlobals, but this ensures that anyones it does provide in the future will be added to the
endowmentson thevat's Compartment. We'll use this to populate
makeExternalStore-typefunctions, which want to be globals (because threading them from
vatPowersinto modules that need them would be too annoying), but must also be in
cahoots with closely-held WeakMaps and "Representative" state management code
from liveslots, as described in #455 and #1846.
closes #1867
@FUDCo reviewer note: the first commit is pure refactoring, the only behavioral changes are in the second commit, feel free to review them separately