Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Zoe] Feedback on the Zoe chaimail #98

Closed
DavidBruant opened this issue Nov 13, 2019 · 4 comments
Closed

[Zoe] Feedback on the Zoe chaimail #98

DavidBruant opened this issue Nov 13, 2019 · 4 comments
Labels
Zoe package: Zoe

Comments

@DavidBruant
Copy link
Contributor

https://github.com/Agoric/ERTP/blob/0a1a6ac1a7eabe1c3fcd28380550afa35412dd84/core/zoe/zoe.chainmail

  • The InstanceInformation interface is not defined
  • installationHandle is an object and there is no corresponding interface (i don't know whether it should)
  • getInstance is said to "Credibly get the instance from the instanceHandle", but returns an InstanceInformation (is "instance" the same thing than "InstanceInformation"?)
  • A bit like for contractHost ( Contract Host without installations #95 ), it's not clear to me how much the installation step is worth the cost of adding another concept. zoe.install(source, terms) (or any better name) could work
@DavidBruant
Copy link
Contributor Author

  • The name burnEscrowReceipt doesn't seem to convey what the method does. While assay.burnAll refers to the destruction of some extent of the assay, burnEscrowReceipt seems to me like it's more of a "transformation" or "exchange" (receipt against offer handle + rules) than a destruction. Maybe "transform" properly conveys the idea of something that disappears and something else appears

@katelynsills
Copy link
Contributor

Thanks for this feedback! Please keep it coming. I think all of the things you mentioned are in flux, so I'll try to make sure that our solutions meet the issues that you've described here.

@warner
Copy link
Member

warner commented Dec 2, 2019

this was issue 219 in the old ERTP repo, and part of the "Zoe - immediate future" project

@warner warner transferred this issue from Agoric/ERTP Dec 2, 2019
@warner warner added the ERTP package: ERTP label Dec 2, 2019
dckc pushed a commit to dckc/agoric-sdk that referenced this issue Dec 5, 2019
@katelynsills katelynsills added Zoe package: Zoe and removed ERTP package: ERTP labels Jan 9, 2020
@katelynsills katelynsills changed the title Feedback on the Zoe chaimail [Zoe] Feedback on the Zoe chaimail Jan 9, 2020
@katelynsills
Copy link
Contributor

Closing this in favor of an updated #496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Zoe package: Zoe
Projects
None yet
Development

No branches or pull requests

3 participants