Make wheel build reproducible #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building wheels for packages, `pip`/`bdist_wheel` may not generate the exact same binary output for C extensions for a few different reasons: * current timestamp is used in the build, can be overridden via `SOURCE_DATE_EPOCH` environment variable * `-g` is used which adds a tmp directory file path to the debuginfo of the binary, can be overridden with `CFLAGS` environment variable * Python hashing with a random seed, can be overridden by `PYTHONHASHSEED` environment variable See bazelbuild/rules_python#15) for more details.
ian-h-chamberlain
approved these changes
Jun 19, 2020
|
I have not (yet). Because this is a fork, I know we can't have issues, but I'm not sure if the same is true about CI. In either case we probably will want to change this to not be a fork, and instead be a standalone project, but one step at a time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS IS A PORT OF apt-itude#43
(which can also be found here: https://github.com/128technology/rules_128tech/blob/master/thirdparty/pip/reproducible_wheel.patch)
When building wheels for packages,
pip/bdist_wheelmay not generatethe exact same binary output for C extensions for a few different
reasons:
current timestamp is used in the build, can be overridden via
SOURCE_DATE_EPOCHenvironment variable-gis used which adds a tmp directory file path to the debuginfo ofthe binary, can be overridden with
CFLAGSenvironment variablePython hashing with a random seed, can be overridden by
PYTHONHASHSEEDenvironment variableSee bazelbuild/rules_python#15) for more
details.