Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove reproducible wheels patch #11

Closed
jacobbogdanov opened this issue Jun 20, 2020 · 1 comment · Fixed by #14
Closed

remove reproducible wheels patch #11

jacobbogdanov opened this issue Jun 20, 2020 · 1 comment · Fixed by #14
Assignees
@ian-h-chamberlain

Comments

@jacobbogdanov
Copy link
Collaborator

since 128technology/rules_pip#1 has been merged to rules_pip,
we should remove the patch from this repo
@ian-h-chamberlain
Copy link
Member

Related: the dep name in this repo is com_apt_itude_rules_pip while downstream uses com_128technology_rules_pip, so any usage of rules defined in this repo will actually be using a different version.

@ian-h-chamberlain ian-h-chamberlain self-assigned this Sep 8, 2020
@ian-h-chamberlain ian-h-chamberlain mentioned this issue Sep 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ian-h-chamberlain ian-h-chamberlain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 128technology rules_pip fork 128technology/rules_128tech
2 participants
@ian-h-chamberlain @jacobbogdanov