Skip to content

Split trophies and edible prizes into separate tasks #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

samjmartin04
Copy link
Contributor

@samjmartin04 samjmartin04 commented May 22, 2025

I accidentally based off of the script-review branch? I couldn't work out how to fix it, but I'm more than happy for someone else to fix it for me. Or we can just merge it as script-review has been merged now?

Comment on lines +16 to +17
We usually have around two awards that have edible prizes.
Typically we give a box of celebrations and a box of jelly babies as the edible prize.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: maybe note something about the motivations here, rather than just what we tend to do? Including the motivation enables the person doing the task to be better informed in case we want to change things.

Suggested change
We usually have around two awards that have edible prizes.
Typically we give a box of celebrations and a box of jelly babies as the edible prize.
We usually have around two awards that have edible prizes.
We should ensure that these account for a variety of tastes and dietary requirements.
Typically we give a box of celebrations and a box of jelly babies as the edible prize.

Copy link
Contributor Author

@samjmartin04 samjmartin04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how easy/possible this is, but it would be good to link to the opposite tasks I think.


description: >-
The prizes for the competition are a combination of trophies and edible prizes.
This task only considers the edible prizes; there is a separate task for trophies.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is easy to do, but if possible, it would be good to link to the trophies task here.


description: >-
The prizes for the competition are a combination of trophies and edible prizes.
This task only considers the trophies; there is a separate task for edible prizes.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is easy to do, but if possible, it would be good to link to the edible prize task here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately that's not possible right now. I have wanted this in the past though, so adding it would be a useful feature. One approach I've considered is to have links to "related" tasks.

A workaround for now might be to link to the template task (i.e: in the recurring tasks repo) instead.

@samjmartin04 samjmartin04 requested a review from Alexbruvv July 9, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants