SG-38306 Python2 Removal - Part 8 - Remove deprecated ensure_ascii parameter from SG object #405
+13
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
julien-lang
force-pushed
the
ticket/SG-38306-python2-various
branch
from
8ac9c8d to
5d8b18d
Compare
julien-lang
force-pushed
the
ticket/SG-38306-python2-ensure-ascii
branch
from
2f109c4 to
f6275cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ensure_ascii parameter was added in the Python 2 world when strings and bytes could be confusing when loading/dumping JSON.
Now, in the Python 3 world, this complexity does not exist anymore as there is clear different between the 2 types. Json dump will always return a string. And loader will convert any "json string" type to a default Python string (i.e. a unicode type in Py2).
PR orders
WIP