SG-38306 Python2 Removal - Part 6 - Remove python2 from httplib2 module #403
+1,811
−9,909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 16, 2025
Open
julien-lang
force-pushed
the
ticket/SG-38306-python2-removal-mock
branch
from
f533371 to
e93ed1e
Compare
julien-lang
force-pushed
the
ticket/SG-38306-python2-removal-httplib2
branch
from
346dc35 to
6124681
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR completes the removal of Python 2 support from the httplib2 module by removing the Python 2 copy of the library and moving the Python 3 version up one directory level. The changes eliminate the version-specific directory structure and consolidate to a single Python 3 implementation.
- Removes all Python 2 httplib2 library files
- Moves Python 3 httplib2 files up one directory level
- Updates import paths and build scripts to reflect the new structure
- Removes Python 2-specific SSL error handling in favor of standard ssl module
Reviewed Changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| update_httplib2.py | Updates build script to handle single httplib2 directory instead of separate python2/python3 folders |
| tests/test_unit.py | Replaces custom ssl_error_classes with standard ssl exceptions and adds ssl import |
| tests/test_api.py | Removes Python 2/3 version detection tests and comments |
| shotgun_api3/shotgun.py | Removes ssl_error_classes import and uses standard ssl.SSLError, ssl.CertificateError |
| shotgun_api3/lib/httplib2/auth.py | Updates relative import path from three levels up to two levels |
| shotgun_api3/lib/httplib2/python3/* | All Python 3 httplib2 files removed (moved up one level) |
| shotgun_api3/lib/httplib2/python2/* | All Python 2 httplib2 files removed |
carlos-villavicencio-adsk
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Python 2 copy of the httplib2 library.
Also, move the library up one level so it's not in a
Python3folder anymore.PR orders
WIP