Skip to content

SG-38306 Python2 Removal - Part 6 - Remove python2 from httplib2 module #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: ticket/SG-38306-python2-removal-mock
Choose a base branch
from

Conversation

@julien-lang julien-lang force-pushed the ticket/SG-38306-python2-removal-httplib2 branch from 346dc35 to 6124681 Compare July 17, 2025 16:27
@julien-lang julien-lang requested a review from Copilot July 17, 2025 17:03
@julien-lang julien-lang marked this pull request as ready for review July 17, 2025 17:03
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR completes the removal of Python 2 support from the httplib2 module by removing the Python 2 copy of the library and moving the Python 3 version up one directory level. The changes eliminate the version-specific directory structure and consolidate to a single Python 3 implementation.

  • Removes all Python 2 httplib2 library files
  • Moves Python 3 httplib2 files up one directory level
  • Updates import paths and build scripts to reflect the new structure
  • Removes Python 2-specific SSL error handling in favor of standard ssl module

Reviewed Changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
update_httplib2.py Updates build script to handle single httplib2 directory instead of separate python2/python3 folders
tests/test_unit.py Replaces custom ssl_error_classes with standard ssl exceptions and adds ssl import
tests/test_api.py Removes Python 2/3 version detection tests and comments
shotgun_api3/shotgun.py Removes ssl_error_classes import and uses standard ssl.SSLError, ssl.CertificateError
shotgun_api3/lib/httplib2/auth.py Updates relative import path from three levels up to two levels
shotgun_api3/lib/httplib2/python3/* All Python 3 httplib2 files removed (moved up one level)
shotgun_api3/lib/httplib2/python2/* All Python 2 httplib2 files removed

@julien-lang julien-lang requested a review from a team July 17, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants